altTab: Restore correct visibility when cycling windows

Commit 3171819c improved window cycling by using a dedicated to clone
for highlighting rather than activating all cycled windows. Original
window actors are hidden while its clone is showing, and shown again
afterwards, however the latter is wrong for actors that are not supposed
to be visible (for example where the window is minimized, or on a different
workspace). Fix this by properly syncing the actor's visibility instead
of showing it unconditionally.

https://bugzilla.gnome.org/show_bug.cgi?id=771536

diff --git a/js/ui/altTab.js b/js/ui/altTab.js
index e65d46b5acd1d665937444f54e362c97c9f56f2a..c2217075bc3eb7153ef45c09857a6c880ef5d875 100644 (file)
--- a/js/ui/altTab.js
+++ b/js/ui/altTab.js
@@ -386,7 +386,7 @@ const CyclerHighlight = new Lang.Class({
         this._window = w;
 
         if (this._clone.source)
-            this._clone.source.show();
+            this._clone.source.sync_visibility();
 
         let windowActor = this._window ? this._window.get_compositor_private()
                                        : null;